Skip to content

refactor(list): easier overriding of list-item height #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2017
Merged

refactor(list): easier overriding of list-item height #8120

merged 1 commit into from
Nov 2, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 30, 2017

  • Makes it easier for developers to override the height of a list-item.

Fixes #8067

@devversion
refactor(list): easier overriding of list-item height
3d17003 
* Makes it easier for developers to override the height of a list-item.

Fixes angular#8067
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 30, 2017
@andrewseguin andrewseguin merged commit c4e12b5 into angular:master Nov 2, 2017
@devversion devversion deleted the refactor/easier-override-height-list-item branch November 20, 2017 19:39
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can override height of mat-list-item, but not mat-list-item-content

5 participants

@devversion @jelbourn @crisbeto @googlebot @andrewseguin