Skip to content

fix(sort): fix arrow on width-constrained headers #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2017
Merged

fix(sort): fix arrow on width-constrained headers #7569

merged 1 commit into from
Oct 9, 2017

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Oct 5, 2017

Fixes this when the container has small width:

6yrmbjqhtsz

@andrewseguin andrewseguin requested a review from jelbourn October 5, 2017 23:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2017
jelbourn
jelbourn approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 6, 2017
@andrewseguin andrewseguin merged commit 147ae46 into angular:master Oct 9, 2017
@andrewseguin andrewseguin deleted the sort-min-width-arrow branch November 28, 2017 20:39
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewseguin @jelbourn @googlebot