Skip to content

fix(overlay): import BidiModule in OverlayModule #7566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

fix(overlay): import BidiModule in OverlayModule #7566

merged 1 commit into from
Oct 6, 2017

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 5, 2017 •
edited
Loading

The ConnectedOverlayDirective uses Directionality, but the OverlayModule doesn't import BidiModule to make it available.

@jelbourn
fix(overlay): import BidiModule in OverlayModule
3a8d4a0 
The ConnectedOverlayDirective uses `Directionality`, but the OverlayModule doesn't current import BidiModule to make it available.
@jelbourn jelbourn requested review from crisbeto and kara October 5, 2017 21:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2017
crisbeto
crisbeto approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 5, 2017
@kara kara merged commit 4321f32 into angular:master Oct 6, 2017
@willshowell willshowell mentioned this pull request Oct 26, 2017
Closed
@jelbourn jelbourn deleted the overlay-module-bidi branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelbourn @crisbeto @kara @googlebot