Skip to content

fix(table): switch when arguments #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

fix(table): switch when arguments #7516

merged 1 commit into from
Oct 31, 2017

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Oct 3, 2017

Fixes #7503

@andrewseguin andrewseguin requested a review from jelbourn October 3, 2017 23:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2017
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Oct 4, 2017

Blocked - going to chat with Misko about the possibility of switching the argument in trackBy

@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label Oct 20, 2017
@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround and removed P4 A relatively minor issue that is not relevant to core functions labels Oct 31, 2017
@andrewseguin andrewseguin requested a review from mmalerba October 31, 2017 19:43
@andrewseguin andrewseguin added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 31, 2017
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Oct 31, 2017

Unblocked - this is actually a breaking change and should be in for the next release

@andrewseguin andrewseguin force-pushed the table-reverse-when-arguments branch from 56658b8 to 1addb75 Compare October 31, 2017 21:11
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 31, 2017
@andrewseguin andrewseguin merged commit a2129fc into angular:master Oct 31, 2017
@andrewseguin andrewseguin deleted the table-reverse-when-arguments branch November 28, 2017 20:38
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Table] Reverse 'when' arguments to align with trackBy

3 participants

@andrewseguin @googlebot @mmalerba