Skip to content

chore: update ng cli, make e2e run sucessfully #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2016
Merged

chore: update ng cli, make e2e run sucessfully #741

merged 1 commit into from
Jun 24, 2016

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Jun 22, 2016 •
edited
Loading

  • Bump the CLI version so that ng e2e surfaces the correct error code
  • Doubles the default protractor timeouts
  • Remove e2e-specific stuff from button demo.
  • Removed the a11y checks, which need to be added back later once the a11y plugin supports passing a configuration through to the underlying AXS.

@jelbourn jelbourn added the in progress This issue is currently in progress label Jun 22, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2016
@jelbourn jelbourn force-pushed the cli-e2e branch 8 times, most recently from f318daf to 9631e83 Compare June 23, 2016 17:53
@jelbourn jelbourn changed the title WIP fix: update ng cli, fix e2e tests chore: update ng cli, make e2e run sucessfully Jun 23, 2016
@jelbourn jelbourn added pr: needs review and removed in progress This issue is currently in progress labels Jun 23, 2016
@jelbourn
Copy link
Member Author

jelbourn commented Jun 23, 2016

R: @robertmesserle @hansl

@robertmesserle
Copy link
Contributor

robertmesserle commented Jun 23, 2016

LGTM

@hansl
Copy link
Contributor

hansl commented Jun 23, 2016

LGTM

@jelbourn jelbourn merged commit 850ac67 into angular:master Jun 24, 2016
@jelbourn jelbourn mentioned this pull request Jun 24, 2016
Closed
@jelbourn jelbourn deleted the cli-e2e branch September 13, 2017 04:36
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelbourn @robertmesserle @hansl @googlebot