fix(input): make autosize work inside tabs & stepper #7341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
|
Actually, add a unit test for stepper + autosize? |
Contributor
Author
|
I feel like this kind of thing is better caught with a screenshot test, which I did for tabs. Didn't add it to the stepper e2e test because it uses the stepper overview example, and I didn't want to start adding irrelevant stuff to the example |
Member
|
An easy sanity test would be to make the initial text really long and assert that the height is above some small-ish threshold |
Contributor
Author
|
done |
jelbourn
reviewed
Sep 26, 2017
src/lib/input/autosize.spec.ts
Outdated
| const fixtureWithForms = TestBed.createComponent(AutosizeTextareaInATab); | ||
| fixtureWithForms.detectChanges(); | ||
| textarea = fixtureWithForms.nativeElement.querySelector('textarea'); | ||
| expect(textarea.getBoundingClientRect().height).toBeGreaterThan(0); |
jelbourn
added
pr: lgtm
action: merge
mmalerba
added
the
P2
andrewseguin
added
pr: needs rebase
and removed
action: merge
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7316