fix(chips): do not set chips value if there's no ngControl or value #7285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 26, 2017
src/lib/chips/chip-list.ts
Outdated
| Promise.resolve().then(() => { | ||
| this._setSelectionByValue(this.ngControl ? this.ngControl.value : this._value, false); | ||
| this.stateChanges.next(); | ||
| if (!!this.ngControl || !!this._value) { |
Member
There was a problem hiding this comment.
You don't need the !! in conditional expressions, only when the value will be passed around somewhere
Contributor
Author
There was a problem hiding this comment.
Done. PTAL. Thanks for review.
Contributor
Author
There was a problem hiding this comment.
Changes are pushed. Thanks!
tinayuangao
force-pushed
the
fix-chip-list
branch
from
1c6e48a to
638adf4
Compare
jelbourn
added
pr: lgtm
action: merge
tinayuangao
force-pushed
the
fix-chip-list
branch
from
638adf4 to
10597dd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7261