Skip to content

feat: update to rxjs 5.5.0 and switch to lettable operators #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2017
Merged

feat: update to rxjs 5.5.0 and switch to lettable operators #7276

merged 1 commit into from
Oct 28, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 23, 2017 •
edited
Loading

Bumps the required RxJS version to 5.5.0 and gets rid of our RxChain in favor of using the lettable Rx operators. Refactors all the usages and updates the configs.

Fixes #7275.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2017
@crisbeto crisbeto force-pushed the 7275/rxjs-lettable branch 3 times, most recently from 0641f9e to 4041c43 Compare September 23, 2017 22:55
@crisbeto crisbeto requested a review from amcdnl as a code owner September 23, 2017 22:55
@crisbeto crisbeto added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed pr: needs review labels Sep 23, 2017
@crisbeto crisbeto assigned crisbeto and unassigned jelbourn Sep 23, 2017
jelbourn
jelbourn approved these changes Sep 24, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this! I was going to dive into it myself when I saw your PR

@jelbourn
Copy link
Member

jelbourn commented Sep 24, 2017

Also blocked on rxjs 5.5 getting into google

@crisbeto crisbeto added the in progress This issue is currently in progress label Oct 20, 2017
@CaerusKaru
Copy link
Member

CaerusKaru commented Oct 21, 2017 •
edited
Loading

@crisbeto Is this unblocked now that angular/angular#19345 is synced? Or are we waiting for 5.0.0 final?

CaerusKaru
CaerusKaru reviewed Oct 21, 2017
View reviewed changes
package.json Outdated
"a-sync-waterfall": "^1.0.0",
"core-js": "^2.4.1",
"rxjs": "^5.0.1",
"rxjs": "5.5.0-beta.7",
Copy link
Member

@CaerusKaru CaerusKaru Oct 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RxJS 5.5.0 is now out of beta, this can be set to ^5.5.0

@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR in progress This issue is currently in progress labels Oct 21, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Oct 21, 2017

Rebased, sorted out any new usages of the RxChain and bumped to 5.5.0 final. @jelbourn unblocking this one and setting it as P1 since it might be nice to have in the RC.

@crisbeto crisbeto force-pushed the 7275/rxjs-lettable branch 3 times, most recently from 2cd7e4d to 37270c8 Compare October 27, 2017 20:52
@crisbeto
feat: update to rxjs 5.5.0 and switch to lettable operators
711d05e 
Bumps the required RxJS version to 5.5.0 and gets rid of our RxChain in favor of using the lettable Rx operators. Refactors all the usages and updates the configs.

Fixes angular#7275.
@rafaelss95 rafaelss95 mentioned this pull request Oct 28, 2017
Closed
@mmalerba mmalerba merged commit f29da63 into angular:master Oct 28, 2017
@IgorMinar
Copy link
Contributor

IgorMinar commented Oct 29, 2017

Awesome work!

@danwulff danwulff mentioned this pull request Nov 1, 2017
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

@kara kara Awaiting requested review from kara

@mmalerba mmalerba Awaiting requested review from mmalerba

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@amcdnl amcdnl Awaiting requested review from amcdnl

+1 more reviewer

@CaerusKaru CaerusKaru CaerusKaru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(rxjs): update to [email protected]

6 participants

@crisbeto @jelbourn @CaerusKaru @IgorMinar @googlebot @mmalerba