Skip to content

Conversation

@devversion
Copy link
Member

  • Adds a test which confirms, that the slide-toggle isn't firing the (change) event multiple times.

Closes #709

… multiple times

* Adds a test which confirms, that the slide-toggle isn't firing the (change) event multiple times.

Closes angular#709
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2016
@devversion devversion changed the title test(slide-toggle): confirm that change event not fires multiple times update(): prevent change event to be fired at initialization Jun 20, 2016
private _renderer: Renderer) {
}

/** @internal */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We figured out in alpha.5 that we can't actually mark life-cycle events as @internal, since they then no longer satisfy the corresponding interface when compiled downstream. So I've been doing TODO: internal for when TS adds a first class internal access modifier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I've heard about that in another issue, but I missed that. Thanks again for the clarification, that makes sense.

@jelbourn
Copy link
Member

LGTM aside from that @internal comment

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit f21b2f4 into angular:master Jun 21, 2016
@devversion devversion deleted the tests/slide-toggle-change-multiple branch November 4, 2016 16:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slide-toggle fires change event on load

3 participants