Skip to content

Conversation

@josephperrott
Copy link
Member

Addresses: #7008

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 12, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 12, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmburnell
Copy link

I tried this fix in my overflow situation and it did not fix it ... due to mat-expansion-panel-body actually grow to the size of its contents. I am still trying to find a fix that works for me, I can post back if i find something.

@tmburnell
Copy link

http://plnkr.co/edit/O5SE55FZ1qlU1il9fh6v?p=preview

I am using codeMirror to display code in the toggled area. My example just mocks the layout.
If you expand one it works fine, however if you expand more than one DUE to flexLayout making the expandable smaller the body container does not get smaller so it overflows into the next item.

@andrewseguin andrewseguin merged commit dcf1074 into angular:master Sep 29, 2017
@gigadie
Copy link

gigadie commented Oct 23, 2017

the fix for this might be changing it from margin to padding:

.mat-expansion-panel-body {
  padding: 0 24px 16px;
  overflow: auto;
}

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
@josephperrott josephperrott deleted the accordion-overflow branch March 20, 2020 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants