fix(common-module): check if computed styles are available #7003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a Firefox Bug (https://bugzilla.mozilla.org/show_bug.cgi?id=548397) the `getComputedStyle` call in the `MdCommonModule` will return `null` and cause a runtime exception because normally the computed styles are never `null` for the test element. Since this it's very uncommon that a developer places a Angular Material application inside of a hidden iframe, a simple null check should be enough to get the application running. Fixes angular#7000
googlebot
added
the
cla: yes
crisbeto
approved these changes
Sep 12, 2017
| if (getComputedStyle(testElement).display !== 'none') { | ||
| const computedStyle = getComputedStyle(testElement); | ||
|
|
||
| if (computedStyle && computedStyle.display !== 'none') { |
Member
There was a problem hiding this comment.
Add a comment that it can potentially be null?
Member
Author
There was a problem hiding this comment.
Done. Please have another look
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Firefox Bug (https://bugzilla.mozilla.org/show_bug.cgi?id=548397) the
getComputedStylecall in theMdCommonModulewill returnnulland cause a runtime exception because normally the computed styles are nevernullfor the test element.Since this it's very uncommon that a developer places a Angular Material application inside of a hidden iframe, a simple null check should be enough to get the application running.
Fixes #7000