Skip to content

Conversation

@amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Aug 28, 2017

Sets left/right padding on desktop to spec ( 24px ). Addresses #3347

@amcdnl amcdnl self-assigned this Aug 28, 2017
@amcdnl amcdnl requested a review from jelbourn August 28, 2017 22:27
@amcdnl amcdnl requested a review from andrewseguin as a code owner August 28, 2017 22:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 28, 2017
@media ($mat-xsmall) {
.mat-tab-label {
min-width: 72px;
padding: 0 12px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only xsmall that should have the denser look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to small per our convo.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 31, 2017
@jelbourn jelbourn merged commit b678119 into angular:master Sep 1, 2017
@amcdnl amcdnl deleted the tabs-spacing-3347 branch September 2, 2017 15:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants