Skip to content

Conversation

@devversion
Copy link
Member

  • Replaces the Regular Expression file matching for the noViewEncapsulation rule with Minimatch. This makes the TSLint configuration more readable and is consistent with other custom rules.

* Replaces the Regular Expression file matching for the noViewEncapsulation rule with Minimatch. This makes the TSLint configuration more readable and is consistent with other custom rules.
@devversion devversion requested a review from jelbourn as a code owner August 24, 2017 13:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 24, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 24, 2017
@kara kara merged commit 6b9c936 into angular:master Aug 24, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants