Skip to content

fix(chips): invalid aria-selected value for non-selectable chip #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017
Merged

fix(chips): invalid aria-selected value for non-selectable chip #6544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/lib/chips/chip.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,8 @@ describe('Chips', () => {
expect(testComponent.chipSelect).not.toHaveBeenCalled();
});

it('should have empty aria-selected', () => {
expect(chipNativeElement.getAttribute('aria-selected')).toBeFalsy();

testComponent.selectable = true;
fixture.detectChanges();

expect(chipNativeElement.getAttribute('aria-selected')).toBe('false');
it('should not have the aria-selected attribute', () => {
expect(chipNativeElement.hasAttribute('aria-selected')).toBe(false);
});
});

Expand Down
4 changes: 2 additions & 2 deletions src/lib/chips/chip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ export class MdChip extends _MdChipMixinBase implements FocusableOption, OnDestr
/** Emitted when the chip is destroyed. */
@Output() destroy = new EventEmitter<MdChipEvent>();

get ariaSelected(): string {
return this.selectable ? this.selected.toString() : '';
get ariaSelected(): string | null {
return this.selectable ? this.selected.toString() : null;
}

constructor(renderer: Renderer2, elementRef: ElementRef) {
Expand Down