Skip to content

fixes to a11y errors #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fixes to a11y errors #654

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adba894
fixes to a11y errors
sendilkumarn Jun 8, 2016
e9728cf
e2e a11y-error fix
sendilkumarn Jun 8, 2016
98477ae
addressing comments to change Google to Search
sendilkumarn Jun 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/demo-app/button/button-demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
</section>

<section>
<a href="http://www.google.com" md-button color="primary">link</a>
<a href="http://www.google.com" md-raised-button>link</a>
<a href="http://www.google.com" md-button color="primary">Google</a>
Copy link
Member

@jelbourn jelbourn Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text should be "SEARCH"

<a href="http://www.google.com" md-raised-button>Google</a>
<a href="http://www.google.com" md-fab>
<md-icon class="md-24">check</md-icon>
</a>
Expand Down Expand Up @@ -81,13 +81,13 @@
</section>
<section>
Link
<a href="http://www.google.com" md-button color="primary">link</a>
<a href="http://www.google.com" md-button color="primary">Google</a>
Button
<button md-button>flat</button>
</section>
<section>
Link
<a href="http://www.google.com" md-raised-button color="primary">link</a>
<a href="http://www.google.com" md-raised-button color="primary">Google</a>
Button
<button md-raised-button>button</button>
</section>
Expand Down
2 changes: 1 addition & 1 deletion src/demo-app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!doctype html>
{{!-- This file is an handlebar file that gets filled at build time. --}}
<html>
<html lang="en">
Copy link
Member

@devversion devversion Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to apply this to the e2e-app as well.

Copy link
Contributor Author

@sendilkumarn sendilkumarn Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this

Copy link
Member

@jelbourn jelbourn Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmesserle is doing this in #650

<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
Expand Down