Skip to content

fix(slider): work around slidestart event sometimes not firing on iOS #6009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

fix(slider): work around slidestart event sometimes not firing on iOS #6009

merged 1 commit into from
Jul 27, 2017

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 24, 2017

fixes #5872

@mmalerba mmalerba requested a review from tinayuangao July 24, 2017 23:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2017
tinayuangao
tinayuangao approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 25, 2017
@andrewseguin andrewseguin merged commit a87a000 into angular:master Jul 27, 2017
@mmalerba mmalerba deleted the slider-ios branch April 3, 2018 15:18
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

md-slider doesn't work correctly in the Safari mobile browser

4 participants

@mmalerba @tinayuangao @googlebot @andrewseguin