Skip to content

fix for checkbox opacity issues in safari #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2016
Merged

fix for checkbox opacity issues in safari #594

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e85799
fix for checkbox opacity issues in safari
sendilkumarn Jun 1, 2016
db62acf
readio
sendilkumarn Jun 2, 2016
ec85b82
Revert "readio"
sendilkumarn Jun 2, 2016
5fb1c7c
updates based on comment
sendilkumarn Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/components/checkbox/checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ md-checkbox {
width: $md-checkbox-size;

[dir="rtl"] & {
margin:{
margin: {
left: $md-checkbox-item-spacing;
right: auto;
}
Expand All @@ -265,9 +265,7 @@ md-checkbox {
.md-checkbox-background {
@extend %md-checkbox-outer-box;

align-items: center;
background-color: $md-checkbox-background-color;
opacity: 0;
align-items: center;
display: inline-flex;
justify-content: center;
transition: background-color $md-checkbox-transition-duration
Expand Down Expand Up @@ -333,15 +331,15 @@ md-checkbox {
.md-checkbox-mixedmark {
transform: scaleX(1) rotate(-45deg);
}

.md-checkbox-background {
opacity: 1;
background-color: $md-checkbox-background-color;
}
}

.md-checkbox-indeterminate {
.md-checkbox-background {
opacity: 1;
background-color: $md-checkbox-background-color;
}

.md-checkbox-checkmark {
Expand All @@ -359,6 +357,13 @@ md-checkbox {
}
}


.md-checkbox-unchecked {
.md-checkbox-background {
background-color: transparent;
}
}

.md-checkbox-disabled {
// NOTE(traviskaufman): While the spec calls for translucent blacks/whites for disabled colors,
// this does not work well with elements layered on top of one another. To get around this we
Expand Down