feat(menu): increase nested menu elevation based on depth #5937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Jul 21, 2017
Contributor
kara
left a comment
kara
left a comment
There was a problem hiding this comment.
LGTM, just nits. Apply label when ready.
src/lib/menu/menu-directive.ts
Outdated
|
|
||
| /** Whether the menu is a sub-menu or a top-level menu. */ | ||
| isSubmenu: boolean = false; | ||
| /** Parent menu os the current menu panel. */ |
src/lib/menu/menu-directive.ts
Outdated
|
|
||
| /** | ||
| * Sets the menu panel elevation. | ||
| * @param depth Amount of parent menus that come before the menu. |
Contributor
There was a problem hiding this comment.
Nit: Amount of parent menus -> Number of parent menus (sounds more natural)
src/lib/menu/menu-directive.ts
Outdated
| */ | ||
| setElevation(depth: number): void { | ||
| // The elevation starts at 2 and increases by one for each level. | ||
| const newElevation = `mat-elevation-z${depth + 2}`; |
Contributor
There was a problem hiding this comment.
Can we make the starting elevation a constant? Like MD_MENU_BASE_ELEVATION
crisbeto
force-pushed
the
nested-menu-elevation
branch
from
389d174 to
e8d08d1
Compare
crisbeto
force-pushed
the
nested-menu-elevation
branch
from
e8d08d1 to
f9054c8
Compare
Contributor
|
Please rebase |
Increases the sub-menu elevation, based on its depth. [Spec for reference](https://material.io/guidelines/material-design/elevation-shadows.html)
crisbeto
force-pushed
the
nested-menu-elevation
branch
from
f9054c8 to
9c319f3
Compare
Member
Author
|
Rebased @andrewseguin. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the sub-menu elevation, based on its depth. Spec for reference