fix(memory): Unsubscribe event listeners when using Observable.fromEvent #5325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
|
@Eddman can you rebase this PR? |
Contributor
Author
|
@jelbourn Done. |
jelbourn
added
pr: lgtm
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
…ent (angular#5325) * Fixed memory leak in CdkMonitorFocus * Unsubscribe events that are registered under window/document using Observable.fromEvent. * Fixed tslint problems.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listeners created using Observable.fromEvent have to be unsubscribed to prevent memory leaks. Especially when the target is document/window.
In addition fixed a small leak in CdkMonitorFocus.
Future TODOs: few services are registering listeners on window/document (eg. FocusOriginMonitor) and theses produce huge leaks in Karma test suites. Angular creates new instances for each spec (in addition to new Zone for each spec). An issue already raised in Zone.js (angular/zone.js/issues/822) to consult what's the correct approach.