Skip to content

fix(input,cdk): a couple of server-side rendering errors #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2017
Merged

fix(input,cdk): a couple of server-side rendering errors #5066

merged 2 commits into from
Jun 12, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 11, 2017

  • Fixes an error that is thrown during server-side rendering if an input has a type.
  • Fixes an error that was being thrown by the cdkObserveContent due to the lack of a MutationObserver.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Jun 11, 2017 •
edited
Loading

@jelbourn The cdkObserveContent error is a little weird. For some reason it is logged, but ends up getting swallowed and doesn't fail the build. The same happens if I throw any kind of error inside the ngAfterContentInit.

@crisbeto
fix(input,cdk): a couple of server-side rendering errors
32ace1c 
* Fixes an error that is thrown during server-side rendering if an input has a `type`.
* Fixes an error that was being thrown by the `cdkObserveContent` due to the lack of a `MutationObserver`.
jelbourn
jelbourn reviewed Jun 12, 2017
View reviewed changes
src/lib/input/input-container.ts
private _isTextarea() {
let nativeElement = this._elementRef.nativeElement;
return nativeElement ? nativeElement.nodeName.toLowerCase() === 'textarea' : false;
let nodeName = this._platform.isBrowser ? nativeElement.nodeName : nativeElement.name;
Copy link
Member

@jelbourn jelbourn Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a comment that explains why this falls back to name
(also shouldn't be necessary long-term since platform-server is changing to mimic more DOM APIs)

Copy link
Member Author

@crisbeto crisbeto Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

src/universal-app/kitchen-sink/kitchen-sink.html

<md-input-container>
<input mdInput [mdDatepicker]="birthday" placeholder="Birthday">
<input type="text" mdInput [mdDatepicker]="birthday" placeholder="Birthday">
Copy link
Member

@jelbourn jelbourn Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any problem with leaving the type empty?

Copy link
Member Author

@crisbeto crisbeto Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I left it in there to avoid regressions.

jelbourn
jelbourn approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 12, 2017
@kara kara merged commit 97e35df into angular:master Jun 12, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @kara @googlebot