Skip to content

Conversation

@devversion
Copy link
Member

  • Moves the packaging out of the tools/gulp folder. This change is in favor of exposing the build-tools to Github (for use in flex-layout)
  • Package tools no longer depend on the task_helpers.ts file from tools/gulp (Necessary for publishing)
  • Relative imports to the packaging have been replaced with material2-build-tools (Useful for sharing existing gulp tasks with flex-layout)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2017
@devversion devversion requested a review from jelbourn June 10, 2017 19:28
* Moves the packaging out of the `tools/gulp` folder. This change is in favor of exposing the build-tools to Github (for use in flex-layout)
* Package tools no longer depend on the `task_helpers.ts` file from `tools/gulp` (Necessary for publishing)
* Relative imports to the packaging have been replaced with `material2-build-tools` (Useful for sharing existing gulp tasks with flex-layout)
@devversion devversion force-pushed the build/move-packaging-to-tools branch from 8f02045 to 6bf497d Compare June 14, 2017 21:01
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 15, 2017
@kara kara merged commit 9945ed7 into angular:master Jun 16, 2017
@devversion devversion deleted the build/move-packaging-to-tools branch June 16, 2017 17:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants