fix(select): panel in multiple mode not overlapping trigger #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Jun 5, 2017
Contributor
kara
left a comment
kara
left a comment
There was a problem hiding this comment.
LGTM, one nit. Apply merge label when ready.
src/lib/select/select.ts
Outdated
| const overlayRect = this.overlayDir.overlayRef.overlayElement.getBoundingClientRect(); | ||
| const viewportRect = this._viewportRuler.getViewportRect(); | ||
| const isRtl = this._isRtl(); | ||
| const extraWidth = this.multiple ? SELECT_MULTIPLE_PANEL_PADDING_X + SELECT_PANEL_PADDING_X : |
Contributor
There was a problem hiding this comment.
Nit: extraWidth is a bit vague. How about paddingWidth ?
* Fixes the select panel in multiple mode not overlapping the trigger completely. * Reformats the select.html to make it a little more manageable. Fixes angular#4943.
crisbeto
force-pushed
the
4943/select-multiple-panel-width
branch
from
f48ace4 to
fbbacbd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4943.