fix(overlay): emit attach and detach at appropriate times #4880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
May 31, 2017
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, just a couple minor comments; can add "merge-ready" when done
| this._attachBackdrop(); | ||
| } | ||
|
|
||
| this._attachments.next(); |
Member
There was a problem hiding this comment.
Add a comment like
// Only emit the `attachments` event once all other setup is done.| this._togglePointerEvents(false); | ||
| this._state.scrollStrategy.disable(); | ||
|
|
||
| let detachmentResult = this._portalHost.detach(); |
crisbeto
force-pushed
the
4871/overlay-callback-order
branch
from
5a1c098 to
cfad200
Compare
crisbeto
force-pushed
the
4871/overlay-callback-order
branch
from
cfad200 to
d81b57c
Compare
Contributor
|
Please rebase |
* Emits the `attachments` when everything has been attached. * Emits the `detachments` when everything has been detached. * Completes the `attachments` observable before the `detachments`. Fixes angular#4871.
crisbeto
force-pushed
the
4871/overlay-callback-order
branch
from
d81b57c to
efea69e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attachmentswhen everything has been attached.detachmentswhen everything has been detached.attachmentsobservable before thedetachments.Fixes #4871.