fix(tooltip): remove native event listener on component destroy #4812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component should clean up events it has registered to. Closes #4499
googlebot
added
the
cla: yes
Contributor
andrewseguin
approved these changes
Jun 14, 2017
Contributor
andrewseguin
left a comment
andrewseguin
left a comment
There was a problem hiding this comment.
LGTM, thanks for the change
andrewseguin
added
pr: lgtm
action: merge
kara
added
pr: needs rebase
and removed
action: merge
Contributor
|
@michastreppel Can you rebase this so we can merge? |
Contributor
Author
|
Changes are now in PR#5144 |
Member
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component should clean up events it has registered to.
Closes #4499