Skip to content

Conversation

@devversion
Copy link
Member

  • The Firebase CLI is not able to properly detect the Firebase functions for the screenshot project. This is because the functions are not re-exported.

* The Firebase CLI is not able to properly detect the Firebase functions for the screenshot project. This is because the functions are not re-exported.
@devversion devversion requested a review from tinayuangao May 25, 2017 17:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 25, 2017
@tinayuangao tinayuangao merged commit affcf5e into angular:master May 25, 2017
@devversion devversion deleted the build/screenshot-functions-deploy branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants