fix(input): correct invalid colors #4771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4651
cc @mmalerba
It was all related to specificity issues, so I decreased the specificity of
.mat-input-ripple's background-color and increased it for.mat-input-placeholder's and.mat-placeholder-required's color.Also, I am unsure as to what the correct behavior for the required asterisk is. Previously, it was
accentwhile floating for all (primary, accent, warn) inputs. It was onlywarnwhen invalid and not focused. I chose to ensure it iswarnat all times when invalid, but can revert if that's contrary to the spec.