Skip to content

fix(autocomplete): show hover style on selected options #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2017
Merged

fix(autocomplete): show hover style on selected options #4724

merged 1 commit into from
May 30, 2017

Conversation

@kara
Copy link
Contributor

@kara kara commented May 22, 2017

Hover styles on previously selected options were being suppressed. To replicate:

  1. Go to docs site example.
  2. Click on 'Alabama'.
  3. Delete text until you have 'A'.
  4. Try to hover over 'Alabama' - no hover style appears.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2017
@kara kara requested a review from jelbourn May 22, 2017 19:06
@kara kara force-pushed the autocomplete-theme branch from be6dfd0 to 1b3e02c Compare May 22, 2017 19:12
@kara kara force-pushed the autocomplete-theme branch from 1b3e02c to 3f344e2 Compare May 22, 2017 19:15
jelbourn
jelbourn approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 22, 2017
@mmalerba mmalerba merged commit b3b6fda into angular:master May 30, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kara @jelbourn @googlebot @mmalerba