Skip to content

Conversation

@robertmesserle
Copy link
Contributor

@robertmesserle robertmesserle commented May 16, 2016

R: @jelbourn @hansl
closes #446

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 16, 2016
@jelbourn
Copy link
Member

LGTM, you can rebase and merge

[spellcheck]="spellcheck"
[attr.maxlength]="maxLength"
[type]="type"
[name]="name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being, this actually needs to be attr.name so that Angular does add an name="null" attribute when it's absent.

@robertmesserle
Copy link
Contributor Author

@jelbourn rebased

@jelbourn jelbourn merged commit f53ffdb into angular:master May 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for name in MdInput

3 participants