fix(dialog): fire afterClosed callback after all dialog actions are done #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
changed the title
crisbeto
force-pushed
the
3890/dialog-afterclosed-order
branch
from
d7f05de to
0c3d90e
Compare
crisbeto
force-pushed
the
3890/dialog-afterclosed-order
branch
2 times, most recently
from
16530c7 to
9d883ff
Compare
crisbeto
force-pushed
the
3890/dialog-afterclosed-order
branch
2 times, most recently
from
e394ff1 to
ec7930a
Compare
* Fires the afterClosed callback once the dialog is removed and the previously-focused element has been refocused. Until now the order was reversed, which prevents people from being able to refocus a different element. * Cleaned up the `MdDialogContainer` logic to simplify it and to remove the need to subscribe to zone events.
crisbeto
force-pushed
the
3890/dialog-afterclosed-order
branch
from
ec7930a to
0809250
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MdDialogContainerlogic to simplify it and to remove the need to subscribe to zone events.