Skip to content

fix: remove deprecated forRoot functions #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2017
Merged

fix: remove deprecated forRoot functions #3539

merged 1 commit into from
Apr 28, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Mar 9, 2017

  • In beta.2 the forRoot calls have been deprecated, and it was stated that those will be removed in the next release (https://goo.gl/2yFPFc)

@devversion devversion requested a review from jelbourn March 9, 2017 19:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2017
@devversion devversion force-pushed the fix/remove-for-root branch from 10964c1 to 41fc5ff Compare March 9, 2017 20:03
@jelbourn
Copy link
Member

jelbourn commented Mar 9, 2017

I kicked off the process to remove all of these from Google apps; we can move forward with this PR once that's done.

@jelbourn
Copy link
Member

jelbourn commented Mar 21, 2017

@devversion I've successfully removed all use of forRoot on material's module inside Google, so this can proceed. No rush, though.

@devversion devversion force-pushed the fix/remove-for-root branch 2 times, most recently from 6c72b36 to 555ec8d Compare March 23, 2017 15:39
@devversion
Copy link
Member Author

devversion commented Mar 23, 2017

@jelbourn Rebased the PR. Please take a look.

@devversion devversion force-pushed the fix/remove-for-root branch from 555ec8d to d2bf729 Compare March 24, 2017 18:16
@devversion
Copy link
Member Author

devversion commented Mar 25, 2017

@jelbourn Is it planned to release this in beta.3 as mentioned in the changelog?

jelbourn
jelbourn approved these changes Mar 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 27, 2017
@devversion devversion force-pushed the fix/remove-for-root branch from d2bf729 to fb4648b Compare March 28, 2017 17:24
@jelbourn
Copy link
Member

jelbourn commented Mar 29, 2017

@devversion I accidentally lied earlier; there were some instances of forRoot that I missed. I'm removing the remaining calls now, will probably take a couple days for approvals.

@jelbourn
Copy link
Member

jelbourn commented Apr 17, 2017

@devversion Okay, I have, at time of this writing, removed all the forRoot from Google. Let's get this rebased before people add more 😄

@devversion devversion force-pushed the fix/remove-for-root branch from fb4648b to ed311c1 Compare April 18, 2017 08:55
@devversion
Copy link
Member Author

devversion commented Apr 18, 2017

@jelbourn Oh yeah. Done!

@jelbourn
Copy link
Member

jelbourn commented Apr 18, 2017

@devversion another forRoot snuck in since yesterday and I realized some people were also using MaterialRootModule, so I'm removing those now.....

@devversion
Copy link
Member Author

devversion commented Apr 20, 2017

@jelbourn Yeah, forRoot is very popular, obviously 😄 Let me know if I need to rebase. I think we have good chances that we don't have to rebase this PR again.

@mmalerba
Copy link
Contributor

mmalerba commented Apr 26, 2017

@devversion needs rebase

@devversion devversion force-pushed the fix/remove-for-root branch from ed311c1 to 11648e7 Compare April 27, 2017 21:20
@devversion
fix: remove deprecated forRoot functions
11578d8 
* In beta.2 the `forRoot` calls have been deprecated, and it was stated that those will be removed in the next release (https://goo.gl/2yFPFc)
@devversion devversion force-pushed the fix/remove-for-root branch from 11648e7 to 11578d8 Compare April 27, 2017 21:21
@mmalerba mmalerba merged commit c94f471 into angular:master Apr 28, 2017
@devversion devversion deleted the fix/remove-for-root branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @mmalerba @googlebot