Skip to content

Conversation

@crisbeto
Copy link
Member

Even though Material is currently decoupled from the animations module, users still need to import the NoopAnimationsModule to disable them.

These changes introduce a custom token so that users don't have to depend on the animations-related packages at all.

Even though Material is currently decoupled from the animations module, users still need to import the `NoopAnimationsModule` to disable them.

These changes introduce a custom token so that users don't have to depend on the animations-related packages at all.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Mar 30, 2025
@crisbeto crisbeto requested a review from a team as a code owner March 30, 2025 07:30
@crisbeto crisbeto requested review from andrewseguin and wagnermaciel and removed request for a team March 30, 2025 07:30
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/core labels Mar 30, 2025
}

/** Injection token used to configure the animations in Angular Material. */
export const MATERIAL_ANIMATIONS = new InjectionToken<AnimationsConfig>('MATERIAL_ANIMATIONS');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this could be a boolean, but I went with the object literal so we can add more options later if necessary.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2025
@crisbeto crisbeto removed the request for review from wagnermaciel March 30, 2025 17:07
@crisbeto crisbeto merged commit 3daa360 into angular:main Mar 30, 2025
23 of 27 checks passed
szoboszlaypali pushed a commit to szoboszlaypali/components that referenced this pull request Apr 1, 2025
angular#30749)

Even though Material is currently decoupled from the animations module, users still need to import the `NoopAnimationsModule` to disable them.

These changes introduce a custom token so that users don't have to depend on the animations-related packages at all.
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
angular#30749)

Even though Material is currently decoupled from the animations module, users still need to import the `NoopAnimationsModule` to disable them.

These changes introduce a custom token so that users don't have to depend on the animations-related packages at all.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: material/core detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants