fix(dialog): prevent error when restoring focus on IE #2771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds an extra null check when restoring focus after a dialog is closed. This is necessary, because the `document.activeElement` can be null in IE. * Switches the focusing logic to use the `Renderer`. Fixes angular#2760.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 23, 2017
| this._ngZone.onMicrotaskEmpty.first().subscribe(() => { | ||
| this._renderer.invokeElementMethod(this._elementFocusedBeforeDialogWasOpened, 'focus'); | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
FYI: using the renderer is fine here, but not exactly necessary since closing a dialog would always be the result of a user action which can only happen once the app is running in the browser.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.activeElementcan be null in IE.Renderer.Fixes #2760.
Note that this is missing a unit test, because it's hard to mock up the
activeElement.