fix(material/schematics): handle input level in typography migration #25949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
amysorto,
devversion,
mmalerba and
wagnermaciel
devversion
approved these changes
Nov 10, 2022
src/material/schematics/ng-generate/mdc-migration/rules/theming-styles.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/theming-styles.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/theming-styles.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/components/typography-config.spec.ts
Outdated
Show resolved
Hide resolved
Expands the logic in the MDC theming migration to be able to discern both keys and values of named Sass function parameters. The new logic is used to correctly migrate users away from the `input` typography levels which doesn't have an equivalent in the new system.
crisbeto
force-pushed
the
mdc-migration-input-level
branch
from
160ce63 to
ca75155
Compare
crisbeto
added a commit
that referenced
this pull request
Nov 10, 2022
…25949) Expands the logic in the MDC theming migration to be able to discern both keys and values of named Sass function parameters. The new logic is used to correctly migrate users away from the `input` typography levels which doesn't have an equivalent in the new system. (cherry picked from commit 1e56524)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the logic in the MDC theming migration to be able to discern both keys and values of named Sass function parameters. The new logic is used to correctly migrate users away from the
inputtypography level which doesn't have an equivalent in the new system.