Skip to content

Conversation

@joejordanbrown
Copy link
Contributor

@joejordanbrown joejordanbrown commented Jan 8, 2017

The padding was not correct because of the media query on xs screens on the md-card padding from 24px to 16px which made md-card-actions have no padding.

Before:
image

After:
image

Material Design specs:
image

The padding was not correct because of the change on xs screens on the md-card padding from 24px to 16px made md-card-actions have no padding.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2017
@jelbourn
Copy link
Member

@joejordanbrown when I look at a card on a small screen size with Chrome dev tools I'm not seeing this issue. Can you make a plunker that demonstrates the problem (along with the screen size under which is happens)?

@dahaupt
Copy link

dahaupt commented Jan 12, 2017

@jelbourn I just did a plunker for this: http://plnkr.co/edit/yznyYcOsQ34SpWF8xxxe
Happens on screen sizes <=600px width.

@jelbourn jelbourn requested a review from kara January 12, 2017 23:05
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 19, 2017
@kara kara removed their assignment Jan 19, 2017
@kara kara merged commit ad0df31 into angular:master Jan 31, 2017
@joejordanbrown joejordanbrown deleted the patch-2 branch August 4, 2017 12:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants