Skip to content

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 3, 2017

  • Transforms the escaped line-breaks from the Firebase private key back into real line-breaks.
    This is necessary because the private key always contains line-breaks.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 3, 2017
* Transforms the escaped line-breaks from the Firebase private key back into real line-breaks.
  This is necessary because the private key always contains line-breaks.
@devversion devversion force-pushed the chore/unescape-line-breaks-payload branch from e4d2db5 to 7b2ea85 Compare January 3, 2017 23:11
@devversion devversion requested a review from jelbourn January 3, 2017 23:11
@devversion
Copy link
Member Author

devversion commented Jan 3, 2017

@jelbourn I wasn't able to verify this change locally since I don't know how Travis CI escapes the characters in their web interface.

Right now the payload mode isn't able to publish the results to firebase.

@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2017

@devversion did you put the key in quotes in Travis, e.g.
image
?

@devversion
Copy link
Member Author

@jelbourn Nope, do I need to?

@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2017

@devversion I think so- I've always had to do that when entering a firebase access token

@devversion
Copy link
Member Author

@jelbourn Interesting, let me try that and restart a build.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 3, 2017
@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2017

LGTM

@kara kara merged commit 82ae2b5 into angular:master Jan 4, 2017
@devversion devversion deleted the chore/unescape-line-breaks-payload branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants