Skip to content

Conversation

@devversion
Copy link
Member

  • Adds some basic e2e tests for the md-slide-toggle component.

Closes #1963.

* Adds some basic e2e tests for the md-slide-toggle component.

Closes angular#1963.
@devversion devversion requested a review from jelbourn December 10, 2016 18:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2016

expect(previousX).not.toBe(newX);
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for toggling with the space key?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Done.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 13, 2016
@jelbourn jelbourn merged commit ac2f784 into angular:master Dec 13, 2016
@devversion devversion deleted the chore/e2e-slide-toggle branch December 13, 2016 19:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tests for slide-toggle

3 participants