Skip to content

Conversation

@kuncevic
Copy link
Contributor

@kuncevic kuncevic commented Dec 9, 2016

fix (gulp task): change Promise<void> to Promise<{}>

When running gulp build or gulp serve:devapp getting an error TSError: ? Unable to compile TypeScript tools\gulp\tasks\release.ts (52,10): Type 'Promise<{}>' is not assignable to type 'Promise<void>'

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 9, 2016
@crisbeto
Copy link
Member

crisbeto commented Dec 9, 2016

It seems like this is the same change as in #2131. I've closed one of them.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 9, 2016
@mmalerba mmalerba merged commit 714c2a4 into angular:master Dec 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants