Skip to content

Conversation

@devversion
Copy link
Member

@devversion devversion commented Dec 5, 2016

ToDo's

  • Need a GitHub token for travis_after_all and for pushing the builds
  • Need a repository like material-builds

Wrote a plugin to wait for all Travis modes to finish (travis-after-modes)

@devversion devversion added the in progress This issue is currently in progress label Dec 5, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2016
@devversion devversion force-pushed the chore/publish-per-commits branch 2 times, most recently from c5037a6 to 6c8ba58 Compare December 8, 2016 21:09
@devversion devversion force-pushed the chore/publish-per-commits branch from 6c8ba58 to 9537d1b Compare December 8, 2016 21:13
@devversion devversion force-pushed the chore/publish-per-commits branch from 1eb2205 to fbb45d7 Compare December 8, 2016 21:34
@devversion devversion force-pushed the chore/publish-per-commits branch from 716e1bc to 22d7dba Compare December 9, 2016 18:57
@devversion devversion added pr: needs review and removed in progress This issue is currently in progress labels Dec 9, 2016
@devversion devversion requested a review from jelbourn December 9, 2016 19:09
@devversion
Copy link
Member Author

@jelbourn Should be good for review. Now using the personal repository as discussed for testing.

@@ -0,0 +1,11 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a top-level comment explaining the purpose of this file

@@ -0,0 +1,43 @@
#!/bin/bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a top-level comment explaining the purpose of this file

cd $(dirname $0)/../..

BUILD_DIR="dist/@angular/material"
BUILD_VERSION=`sed -nE 's/^\s*"version": "(.*?)",$/\1/p' package.json`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using $( ... ) over ticks for bash:

# Extract the current version from package.json
BUILD_VERSION=$(sed -nE 's/^\s*"version": "(.*?)",$/\1/p' package.json)

(here and elsewhere)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 9, 2016
@mmalerba mmalerba merged commit 58d2aa3 into angular:master Dec 9, 2016
@devversion devversion deleted the chore/publish-per-commits branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants