Skip to content

Conversation

@crisbeto
Copy link
Member

  • Adds the ability to switch focus between list items using the up/down keys.
  • Splits up the various list-related components into separate files.

Fixes #941.

* Adds the ability to switch focus between list items using the up/down keys.
* Splits up the various list-related components into separate files.

Fixes angular#941.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2016
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate.

Relates to angular#1999.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate.

Relates to angular#1999.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 28, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate.

Relates to angular#1999.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 29, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate.

Relates to angular#1999.
tinayuangao pushed a commit that referenced this pull request Dec 1, 2016
Calls preventDefault when handling keyboard events in the ListKeyManager. This avoids the user scrolling the page when using the arrow keys to navigate.

Relates to #1999.
@jelbourn
Copy link
Member

jelbourn commented Dec 2, 2016

@crisbeto I double-checked the w3c docs for ths, and I think we don't want to make this change. <md-list> by itself is a role="list" element, which is meant to be non-interactive.

The keyboard interaction would come into play when we implement <md-selection-list> (which would be role="listbox")

@crisbeto
Copy link
Member Author

crisbeto commented Dec 2, 2016

I see. I wasn't aware that md-selection-list was a planned component. Closing in that case.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Keyboard navigation in md-list

3 participants