Skip to content

chore: fix unit broken unit tests and CI not running them #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2016
Merged

chore: fix unit broken unit tests and CI not running them #1834

merged 2 commits into from
Nov 12, 2016

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 11, 2016

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2016
@jelbourn jelbourn added in progress This issue is currently in progress and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 11, 2016
@jelbourn jelbourn changed the title WIP Karma fix chore: fix unit broken unit tests and CI not running them Nov 11, 2016
@jelbourn jelbourn added pr: needs review and removed in progress This issue is currently in progress labels Nov 11, 2016
@jelbourn
Copy link
Member Author

jelbourn commented Nov 12, 2016

R: @kara

CC: @crisbeto merging #1741 caused Travis to no longer run any unit tests. Because of that, we didn't notice that #1716 broke a bunch of unit tests.

This PR fixes the broken tests from #1716 and reverts #1741.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2016
kara
kara approved these changes Nov 12, 2016
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 175f2d8 into angular:master Nov 12, 2016
@jelbourn jelbourn deleted the karma-fix branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn @kara @googlebot