fix(menu): improve a11y for screenreaders #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 8, 2016
src/lib/core/a11y/fake-mousedown.ts
Outdated
| * real mousedowns will indicate the mouse button that was pressed (e.g. "1" for | ||
| * the left mouse button), faked mousedowns will usually set the property value to 0. | ||
| */ | ||
| export function isFakeMousedown(event: MouseEvent): boolean { |
Member
There was a problem hiding this comment.
I still kind of want to call this isFakeMousedownFromScreenReader...
| this._setIsMenuOpen(false); | ||
|
|
||
| if (this._openedFromKeyboard) { | ||
| if (!this._openedByMouse) { |
Member
There was a problem hiding this comment.
Add comment here explaining why we only want to set focus when it's opened via keyboard.
Member
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes keyboard navigation for JAWS and NVDA screenreaders. Needs rebase once menu animations PR goes in.
Closes #1673.