Skip to content

fix(button): set vertical alignment for md-button and md-raised-button #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2016
Merged

fix(button): set vertical alignment for md-button and md-raised-button #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f88e42
Set vertical alignment for md-button and md-raised-button so md-icon …
tinayuangao Oct 21, 2016
8eaf6dc
revert the span change
tinayuangao Oct 21, 2016
c3544aa
Add comments for style
tinayuangao Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/demo-app/button/button-demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,16 @@
<a href="http://www.google.com" md-raised-button color="primary">SEARCH</a>
<button md-raised-button>DANCE</button>
</section>
<section>
<button md-raised-button>More<md-icon>more_vert</md-icon></button>
<button md-raised-button>Check<md-icon>check</md-icon></button>
<button md-raised-button>Check<md-icon class="md-24">favorite</md-icon></button>
<button md-raised-button>Last<md-icon>navigate_before</md-icon></button>
</section>
<section>
<button md-button>More<md-icon>more_vert</md-icon></button>
<button md-button>Check<md-icon>check</md-icon></button>
<button md-button>Check<md-icon class="md-24">favorite</md-icon></button>
<button md-button>Last<md-icon>navigate_before</md-icon></button>
</section>
</div>
7 changes: 7 additions & 0 deletions src/lib/button/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@
}
}

// The text and icon should be vertical aligned inside a button
[md-button], [md-raised-button] {
Copy link
Member

@jelbourn jelbourn Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment that explains what this style is for / why it was added?

Copy link
Contributor Author

@tinayuangao tinayuangao Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.md-button-wrapper > * {
vertical-align: middle;
}
}

// The ripple container should match the bounds of the entire button.
.md-button-ripple {
position: absolute;
Expand Down