Skip to content

Conversation

@jelbourn
Copy link
Member

R: @hansl

This is the first step towards adding a general solution focus trapping, with the first goal of supporting MdDialog. I drew a lot of knowledge from ally.js.

Current checks are basic compared to the robustness of ally.js, but should capture most common use cases.

@jelbourn jelbourn added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Sep 21, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2016
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to export that out of core yet?

@jelbourn
Copy link
Member Author

I'll add an export when I start using it elsewhere. Looks like there's a legit failure on IE11 and Edge, though.

@jelbourn
Copy link
Member Author

@hansl Fixed IE and Edge problem, any further comments?

@hansl
Copy link
Contributor

hansl commented Sep 21, 2016

LGTM.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2016
@kara kara merged commit 8a4b69d into angular:master Sep 23, 2016
@jelbourn jelbourn deleted the focus-trapping branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants