feat(packaging): move packaging to a single "@angular/material" #1286
Conversation
googlebot
added
the
cla: yes
hansl
force-pushed
the
all
branch
2 times, most recently
from
59f2229 to
11aa070
Compare
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, just a few requests for comments
src/demo-app/system-config.ts
Outdated
|
|
||
| const _cliSystemConfig: any = angularPackages; | ||
|
|
||
| const angularPackages: any = angularDeps.reduce((config: any, pkg: string) => { |
There was a problem hiding this comment.
Add comment like "Create packages for each angular dependency, of the form..."
There was a problem hiding this comment.
System-Config has been simplified. PTAL
src/demo-app/system-config.ts
Outdated
| angularPackages[barrelName] = { main: 'index' }; | ||
| }); | ||
|
|
||
| const angularMaps: any = angularDeps.reduce((config: any, pkg: string) => { |
There was a problem hiding this comment.
Add comment like "Create SystemJS map containing all of the Angular dependencies. Of the form..."
There was a problem hiding this comment.
System-Config has been simplified. PTAL
tools/gulp/tasks/components.ts
Outdated
| writeFileSync( outputPath, result.code ); | ||
| }); | ||
| }, Promise.resolve()); | ||
| // Build the all package. |
There was a problem hiding this comment.
Comment something like "Use rollup to create the published umd bundle." ?
hansl
force-pushed
the
all
branch
2 times, most recently
from
36eaa0d to
c71e9b1
Compare
|
@jelbourn: this is ready to be reviewed. Sourcemaps are still messy (they give the |
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
Just one comment, otherwise lgtm
| @import '../../slider/slider-theme'; | ||
| @import '../../tabs/tabs-theme'; | ||
| @import '../../toolbar/toolbar-theme'; | ||
| @import '../../tooltip/tooltip-theme'; |
There was a problem hiding this comment.
Want to move this mixin into _theming.scss and just delete this file?
|
Okay. Will do that when I'm back from dinner |
hansl
added
action: merge
jelbourn
added
pr: lgtm
and removed
action: merge
src/lib/core/theming/_theming.scss
Outdated
|
|
||
|
|
||
| // Create a theme. | ||
| @mixin angular-material-theme($theme) { |
There was a problem hiding this comment.
As discussed: internal presubmit revealed that moving this here caused an unresolvable circular dependency. Need to move it back to it's own file. I suggest we call it _all-component-themes.scss
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Moving forward, we will only publish a single
@angular/materialpackage for the Angular2 Material project. This simplifies installation and usage for everyone, and won't increase the size of the library for people using AoT. It is also assumed that most people who use Angular Material will use most of the components so using a single UMD bundle should not increase their package size too much in JIT.BREAKING CHANGES
People using
npm install @angular2-material/COMPONENT_NAMEneed to remove all their@angular2-materialdependencies and use a single@angular/materialdependency instead.