refactor(dialog): normalize event names #11549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| * @deprecated Use `afterOpened` instead. | ||
| * @deletion-target 7.0.0 | ||
| */ | ||
| afterOpen(): Observable<void> { |
Member
There was a problem hiding this comment.
Since this is in cdk-experimental we do not have to go through the deprecation process, we can just change the name.
jelbourn
reviewed
May 29, 2018
| /** | ||
| * Gets an observable that emits when dialog is finished opening. | ||
| * @deprecated Use `afterOpened` instead. | ||
| * @deletion-target 7.0.0 |
Member
There was a problem hiding this comment.
Needs to be 8.0 if we're deprecating it now
crisbeto
force-pushed
the
dialog-consistent-events
branch
from
7b0657b to
a06ea8c
Compare
Member
Author
|
Addressed the feedback @jelbourn @josephperrott. |
jelbourn
added
pr: lgtm
action: merge
josephperrott
added
pr: needs rebase
and removed
action: merge
Member
|
@crisbeto Can you rebase this? There have been changes to the dialog that introduced new usages of the properties being renamed in this PR. |
A while ago we made the output names of components consistent (e.g. angular#8053 and angular#8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.
crisbeto
force-pushed
the
dialog-consistent-events
branch
from
a06ea8c to
27e170a
Compare
crisbeto
added
action: merge
Member
Author
|
Rebased and sorted out the compilation error. |
josephperrott
pushed a commit
that referenced
this pull request
Aug 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we made the output names of components consistent (e.g. #8053 and #8052), however that didn't cover the methods on the dialog. These changes align the dialog event names with the ones on the various components.