fix(@angular-devkit/build-angular): provide option to run build-optimizer on server bundles #25070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
Apr 26, 2023
packages/angular_devkit/build_angular/src/builders/server/schema.json
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
build-optimizer-server-build
branch
from
b17f4d1 to
bb65324
Compare
alan-agius4
added
action: review
clydin
approved these changes
Apr 26, 2023
packages/angular_devkit/build_angular/src/builders/server/schema.json
Outdated
Show resolved
Hide resolved
…izer on server bundles This commit adds the option to run build-optimizer on the server bundles. This is needed as in some cases, there can be restrictions on the size of server bundles that can be executed. One of these cases is CloudFlare workers which by default does not work with an `ng-new` application due to the size of the bundle mainly due to the retention of the `@angular/compiler`.
alan-agius4
force-pushed
the
build-optimizer-server-build
branch
from
bb65324 to
d4a7787
Compare
alan-agius4
added
action: merge
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Apr 27, 2023
…izer on dev server builds In angular#25070 we turned on `buildOptimizer` by default for server builds. This causes existing projects development builds to always run build-optimizer. This migration will set `buildOptimizer` to false, when `optimization` is disabled.
angular-robot bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
…izer on dev server builds In #25070 we turned on `buildOptimizer` by default for server builds. This causes existing projects development builds to always run build-optimizer. This migration will set `buildOptimizer` to false, when `optimization` is disabled.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option to run build-optimizer on the server bundles.
This is needed as in some cases, there can be restrictions on the size of server bundles that can be executed. One of these cases is CloudFlare workers
which by default does not work with an
ng-newapplication due to the size of thebundle mainly due to the retention of the
@angular/compiler.//cc @AndrewKushnir