fix(build): Cope with tags not conforming to semver format when building. #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. If a developer had defined a git tag which did not conform to the semver format "vx.y.z", the build process would take this tag and assume it to be the current version but fail when it does not. The script now skips these tags. It might also make sense to warn about these tags, as the developer may have had a typo. But this still enforces the pattern to only have tags in that format. Before this fix, if such a tag had been defined the following error message appeared: $ grunt Loading "Gruntfile.js" tasks...ERROR >> TypeError: Cannot read property 'match' of null
vishalnarewade
pushed a commit
to vishalnarewade/ui-grid
that referenced
this pull request
Nov 6, 2017
…ing. (angular-ui#6376) If a developer had defined a git tag which did not conform to the semver format "vx.y.z", the build process would take this tag and assume it to be the current version but fail when it does not. The script now skips these tags. It might also make sense to warn about these tags, as the developer may have had a typo. But this still enforces the pattern to only have tags in that format. Before this fix, if such a tag had been defined the following error message appeared: $ grunt Loading "Gruntfile.js" tasks...ERROR >> TypeError: Cannot read property 'match' of null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a developer had defined a git tag which did not conform to the semver format "vx.y.z", the build
process would take this tag and assume it to be the current version but fail when it does not. The
script now skips these tags. It might also make sense to warn about these tags, as the developer may
have had a typo. But this still enforces the pattern to only have tags in that format.
Before this fix, if such a tag had been defined the following error message appeared: