Fixes bug with backdrop click #5911
Conversation
Fixes bug with text selection and mouse up event on modal backdrop.
|
If you would like us to consider merging this, you will need to add tests and correctly fix the issue that caused the build to break. |
|
The implementation should be changed to something similar to this from Bootstrap |
|
@no1lov3sme, do you intend on fixing the issues with this PR or shall I close it? Thanks. |
|
@icfantv, please specify ehat should be fixed. I've already refactored the code in my last commit; tests are passing. |
|
@no1lov3sme, see the comment from @wesleycho. |
| var selector = 'body > div.modal'; | ||
| $document.find(selector).mousedown(); | ||
| $document.find(selector).mouseup(); | ||
| $document.find(selector).click(); |
There was a problem hiding this comment.
This should be in a separate test - you could just copy/paste the test this is modifying, and revert the original test.
|
Any news on this? |
|
there's a line 'element.one'... is that supposed to be element.on? |
|
|
7 participants
Fixes bug when selecting text and moving mouse away from modal container to the backdrop and releasing mouse button.