Fix formatting not running on samples #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting can now be run using scripts/format.sh
riggaroo
reviewed
Sep 26, 2022
| @@ -8,10 +12,11 @@ androidx-benchmark-junit4 = "1.1.0-beta04" | |||
| androidx-constraintlayout = "1.0.1" | |||
| androidx-corektx = "1.8.0" | |||
| androidx-lifecycle-compose = "2.5.1" | |||
| androidx-lifecycle-runtime-compose = "2.6.0-alpha02" # merge with above when not alpha | |||
There was a problem hiding this comment.
Is this intentional for this PR?
There was a problem hiding this comment.
Yes. This PR added it but didn't add it to the global file. #970
riggaroo
reviewed
Sep 26, 2022
| androidx-test = "1.4.0" | ||
| androidx-test-espresso = "3.4.0" | ||
| androidx-test = "1.3.0" | ||
| androidx-test-espresso = "3.3.0" |
There was a problem hiding this comment.
I was getting annoying dependency clashes in one of the samples, but I will fix this before merging
There was a problem hiding this comment.
OK it seems compose 1.3 beta03 pins to these versions so we will have to go with this for now. I assume this will be upgraded again in the next release.
|
I think this might be a bug in actions :( It's meant to run the updated workflow but because we use a shared file, it goes and pulls the one from main instead. I'm not sure how we can work around this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting is now done using the
scripts/format.shscript