Compose navigation in reply #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gurupreet
commented
May 25, 2022
| } | ||
|
|
||
| class ReplyNavigationActions(navController: NavHostController) { |
There was a problem hiding this comment.
I noticed JetNews used this actions implementation which seems very good for top level navigation. Hence I adopted it too. Let me know what you think on it @florina-muntenescu
There was a problem hiding this comment.
Gurupreet
commented
May 25, 2022
ricknout
reviewed
May 26, 2022
ricknout
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add compose navigation to reply
-Add empty screens to remaining tabs